This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Extend cli options #2322
Merged
Extend cli options #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[bugfix] exit with 0 on type check errors when `--force` is specified Fixes: #2087 [bugfix] `--test` now correctly strips single quotes from patterns on windows [enhancement] `--test` can handle multiple paths at once [enhancement] added `-p` as shorthand for `--project` to be consistent with `tsc` Kind of fixes: #2291 [enhancement] print error when `--type-check` is used without `--project` [enhancement] don't print stack trace on type check error
nchen63
suggested changes
Mar 10, 2017
src/runner.ts
Outdated
| } | ||
| } finally { | ||
| } catch (e) { |
There was a problem hiding this comment.
why is this in a catch instead of a finally? The file descriptor should be closed regardless of what happens. Line 231 can be removed too
There was a problem hiding this comment.
good catch, I thought finally would not be executed when leaving the try block with return or continue. Will revert that change
nchen63
approved these changes
Mar 10, 2017
|
@ajafff thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
--forceactive #2087Overview of change:
[bugfix] exit with 0 on type check errors when
--forceis specifiedFixes: #2087
[bugfix]
--testnow correctly strips single quotes from patterns on windows[enhancement]
--testcan handle multiple paths at once^useful when shell expands globs
[enhancement] added
-pas shorthand for--projectto be consistent withtscKind of fixes: #2291
[enhancement] print error when
--type-checkis used without--project[enhancement] don't print stack trace on type check error