This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Specify minimum version of typescript for tests #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
[development] allow rule tests to specify version requirement for typescript
This should unblock #2219
Is there anything you'd like reviewers to focus on?
I just implemented what I proposed in the linked issue #2304 (comment). If you have another idea, let me know.
The prerelease suffix is removed before matching. Otherwise matching nightly builds of typescript would be pretty nasty: https://github.com/npm/node-semver#prerelease-tags