Add OPTION_ALLOW_SNAKE_CASE to variable name options

[AJamesPhillips]

PR checklist

• Addresses an existing issue: Rule option request: snake_case for variable-name rule #2190
• Is an enhancement
• Does includes tests
• Documentation is updated (assuming the documentation comes from metadata on the Rule itself).

Overview of change:

Add OPTION_ALLOW_SNAKE_CASE to variable name options

CHANGELOG.md entry:

[new-rule-option] "allow-snake-case" option for `variable-name` rule (#2190)

Please let me know if there's anything else you need / would like to change. Many thanks.

[palantirtech]

Thanks for your interest in palantir/tslint, @AJamesPhillips! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[ajafff]

LGTM. I just had one comment, but that's no blocker.

Unfortunately this conflicts with the not yet landed PR #2355. Applying your changes on top of the other PR should not be diffucult, though.

[ajafff]

you don't need a getter for this, just do it once in the constructor

[AJamesPhillips]

Thanks for the speedy response @ajafff . I made the change to the getter for formatFailure and then rebased onto 2355 but it's got all those "Abc committed with AJP..." commits. That ok or is there a preferred way of doing it like cherry-pick?

[ajafff]

Your changes still LGTM after rebase.

got all those "Abc committed with AJP..." commits

I think that's ok for now. It would be nice if you can interactive rebase / cherry-pick on master once #2355 landed.

[AJamesPhillips]

Sure thing, will do.

[adidahiya]

sorry for the delay; I have now merged #2355

[ajafff]

github did not send a notification email for the last force push

ping @adidahiya this is ready to merge unless you have any objections

[adidahiya]

thanks @AJamesPhillips!