This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add regression test for invalid JSX #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add regression test to avoid crashes on invalid JSX. Fixes: #2330
adidahiya
suggested changes
Mar 23, 2017
yarn.lock
Outdated
| version "1.2.2" | ||
| resolved "https://registry.yarnpkg.com/tsutils/-/tsutils-1.2.2.tgz#7e165c601367b9f89200b97ff47d9e38d1a6e4c8" | ||
|
|
||
| tsutils@^1.4.0: |
There was a problem hiding this comment.
now we have two copies of tsutils, this looks wrong
There was a problem hiding this comment.
fixed.
this was caused by the dependency on tslint@latest which locked that dependency of tsutils when it was installed.
| const a = | ||
| <span / | ||
| > | ||
| </span> |
adidahiya
approved these changes
Mar 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Add regression test to avoid crashes on invalid JSX.
Fixes: #2330
CHANGELOG.md entry:
[no-log]