This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
unified-signatures: Convert to function #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hanson
force-pushed
the
unified-signatures
branch
from
b0f7e7b to
ee1fa41
Compare
andy-hanson
force-pushed
the
unified-signatures
branch
from
ee1fa41 to
1c95059
Compare
ajafff
reviewed
Mar 28, 2017
| checkStatements(sourceFile.statements); | ||
| return ts.forEachChild(sourceFile, function cb(node: ts.Node): void { | ||
| switch (node.kind) { | ||
| case ts.SyntaxKind.ModuleBlock: |
There was a problem hiding this comment.
add a case for ts.SyntaxKind.Block?
There was a problem hiding this comment.
TypeScript won't let you write non-adjacent signatures in a regular block.
nchen63
approved these changes
May 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Just a refactor.