This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
interface-name: Convert to function #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
approved these changes
Apr 2, 2017
src/rules/interfaceNameRule.ts
Outdated
| } | ||
| } | ||
| return ts.forEachChild(node, cb); |
There was a problem hiding this comment.
nit: you could move this line to the else branch, because interfaces cannot occur inside other interfaces
adidahiya
approved these changes
Apr 3, 2017
jkillian
reviewed
Apr 3, 2017
| import * as ts from "typescript"; | ||
|
|
||
| import * as Lint from "../index"; | ||
| import { isUpperCase } from "./variableNameRule"; |
There was a problem hiding this comment.
I'd recommend moving this to a separate file that is imported by both this rule and variableNameRule. Helps avoid circular dependencies and in a few edge cases, circular dependencies can cause runtime issues to pop up which is never fun. Also, no semantic reason for isUpperCase to live in variableNameRule imo
(sorry for the drive-by comment after this was merged! Just happened to notice it haha)
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Just a refactor.