This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
object-literal-sort-keys: rewrite, handle spread and shorthand #2592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
object-literal-shorthand
disablesobject-literal-sort-keys
#2205, object-literal-sort-keys does not handle spreads well #2554Overview of change:
[new-rule-option]
object-literal-sort-keys
addsignore-case
Fixes: #1924
[enhancement]
object-literal-sort-keys
: check shorthand propertiesFixes: #2205
[bugfix]
object-literal-sort-keys
: handle object spread correctlyFixes: #2554
Is there anything you'd like reviewers to focus on?
Numbers are still excluded because it doesn't make sense to sort them alphabetically.
Methods and accessors are also still ignored.