Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Clean up no-switch-case-fallthrough #2601

Merged
merged 1 commit into from
Apr 29, 2017
Merged

Clean up no-switch-case-fallthrough #2601

merged 1 commit into from
Apr 29, 2017

Conversation

andy-hanson
Copy link
Contributor

@andy-hanson andy-hanson commented Apr 19, 2017 •
edited by nchen63
Loading

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

  • Reduce casts
  • Create commentText helper
  • Use .forEach and .some
    [no-log]

@andy-hanson andy-hanson force-pushed the no-switch-case-fall-through branch from 27b41b1 to 40750c1 Compare April 19, 2017 01:27
@nchen63 nchen63 merged commit dbc774e into palantir:master Apr 29, 2017
@andy-hanson andy-hanson deleted the no-switch-case-fall-through branch April 29, 2017 17:40
@renovate-bot renovate-bot mentioned this pull request May 3, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nchen63 nchen63 nchen63 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy-hanson @nchen63