Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

no-default-export: rewrite and fix export default bug #2630

Merged
merged 2 commits into from
May 7, 2017
Merged

no-default-export: rewrite and fix export default bug #2630

merged 2 commits into from
May 7, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Apr 23, 2017

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Rewrite to walker function and only check top level statements. Excluding declaration files, because they only declare what is already available from some module.
[bugfix] no-default-export: correctly handle export default abstract class {...}

Is there anything you'd like reviewers to focus on?

The rule only checks top level statements, because typescript doesn't allow default exports in namespaces.
Default exports are allowed in declare module "foo", but they are not checked for the same reason as declaration files (see above)

CHANGELOG.md entry:

ajafff added 2 commits April 23, 2017 11:52
Rewrite to walker function and only check top level statements.
[bugfix] `no-default-export`: correctly handle `export default abstract class {...}`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants