This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
no-parameter-properties: Rewrite to walker function #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[no-log] just refactoring
andy-hanson
reviewed
May 7, 2017
| if (isParameterProperty(parameter)) { | ||
| ctx.addFailure(parameter.getStart(ctx.sourceFile), | ||
| parameter.name.pos, | ||
| Rule.FAILURE_STRING_FACTORY((parameter.name as ts.Identifier).text)); |
There was a problem hiding this comment.
Nit: Use parameter.name.getText() to avoid crashing on a grammar error.
There was a problem hiding this comment.
it wouldn't crash, it would just result in undefined. Anyways, I fixed it and added a test to ensure it works
adidahiya
approved these changes
May 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[no-log] just refactoring