Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Enable 'deprecation' rule #2676

Merged
merged 1 commit into from
May 6, 2017
Merged

Conversation

andy-hanson
Copy link
Contributor

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Just enables the rule and fixes failures.

@@ -57,11 +57,11 @@ class Walker extends Lint.ProgramAwareRuleWalker {
}

for (const d of decSym.getDeclarations()) {
let commentNode: ts.Node = d;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, did the rule make that change necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the comment included the string "@deprecated", so the declaration of commentNode was considered deprecated.

@nchen63 nchen63 merged commit 78853ca into palantir:master May 6, 2017
@andy-hanson andy-hanson deleted the deprecation branch May 6, 2017 04:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants