This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix findup when file found in subdirectory #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this fixed by #2720? |
|
Seems like this fixes it. You can add the tests from this PR to make sure it does |
Merged
andy-hanson
added a commit
to andy-hanson/tslint
that referenced
this pull request
May 19, 2017
nchen63
approved these changes
May 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
The new
findupimplementation missed apath.join(...)and just returned the filename.This fixes the bug and adds tests to ensure it will not regress.
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[no-log] because that's not yet released