This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
prefer-object-spread: lint more locations, allow first parameter with side effects #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… side effects [bugfix] `prefer-object-spread`: allow constructor, function and method calls as first argument to `Object.assign` [enhancement] `prefer-object-spread`: lint more locations where return value is used.
adidahiya
approved these changes
May 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
[bugfix]
prefer-object-spread: allow constructor, function and method calls and more as first argument toObject.assignFixes: #2824
[enhancement]
prefer-object-spread: lint more locations where return value is used.Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: