Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Since 5.4.0 --exclude does not work anymore #2852

Closed
Martin-Luft opened this issue Jun 1, 2017 · 2 comments · Fixed by #2853
Closed

Since 5.4.0 --exclude does not work anymore #2852

Martin-Luft opened this issue Jun 1, 2017 · 2 comments · Fixed by #2853

Comments

@Martin-Luft
Copy link

Bug Report

  • TSLint version: 5.4.0
  • TypeScript version: 2.3.4
  • Running TSLint via: CLI

Since 5.4.0 --exclude does not work anymore and breaks my build :(

tslint --config ./tslint.json --exclude '**/server-api/**' --project ./tsconfig.json --type-check

The server-api directory contains generated code which cannot be linted and therefore must be excluded.

|-tslint.json
|-tsconfig.json
|-src
  |-server-api
    |-...
  |-app
    |-...
|-...

Until 5.3.2 this worked like a charme...

@sandersn
Copy link
Contributor

sandersn commented Jun 1, 2017

This doesn't seem to be fixed in 5.4.1. Typescript's build is still failing, for example:

https://travis-ci.org/Microsoft/TypeScript/jobs/238410879

You can repro this locally with gulp lint after cloning Microsft/TypeScript and running npm install. Our command is as follows:

node node_modules/tslint/bin/tslint Gulpfile.ts 'scripts/tslint/*.ts' 'src/**/*.ts' --exclude src/lib/es5.d.ts --exclude 'src/lib/*.generated.d.ts' --format stylish

@Martin-Luft
Copy link
Author

For me 5.4.1 fixed the problem...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants