This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Bugfix --project with --fix #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
approved these changes
Jun 16, 2017
test/executable/executableTests.ts
Outdated
| this.slow(4000); | ||
| this.timeout(6000); | ||
| fs.writeFileSync("test/files/project-multiple-fixes/testfile.test.ts", | ||
| fs.readFileSync("test/files/project-multiple-fixes/before.test.ts", "utf-8")); |
There was a problem hiding this comment.
we could probably use some better infrastructure so all this juggling isn't required. but this is fine for now.
|
@ajafff could you resolve the merge conflicts please? |
|
@adidahiya done, resolved merge conflicts and fixed new lint errors |
adidahiya
approved these changes
Jun 19, 2017
This was referenced Jul 6, 2017
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
A
Programis immutable. Hence it was never updated when applying fixes. The following fixes for the same file were applied at the wrong location.Now we update the
Program(create a new one) after every fix.[bugfix] Avoid overlapping fixes when using
--projectand--fixFixes: #2862
Fixes: #2641
Fixes: #2326
Fixes: #2877
Is there anything you'd like reviewers to focus on?
The implementation assumes that the program has been created with the default
Host. That may not be the case if tslint is used as a library and the program is passed from outside. We would need a new API to get that working. That's tracked by microsoft/TypeScript#16217CHANGELOG.md entry: