This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Added allow-empty-catch option to no-empty #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows catch blocks to be empty. Fixes #1088.
ajafff
reviewed
Jun 4, 2017
src/rules/noEmptyRule.ts
Outdated
| @@ -59,6 +71,16 @@ function walk(ctx: Lint.WalkContext<void>) { | |||
| }); | |||
| } | |||
|
|
|||
| function isExcluded(node: ts.Node, options: Options): boolean { | |||
| const { parent } = node; | |||
| if (parent === undefined) { | |||
There was a problem hiding this comment.
parent will never be undefined here
src/rules/noEmptyRule.ts
Outdated
| } | ||
|
|
||
| return isExcludedConstructor(parent) | ||
| || (options.allowEmptyCatch === true && parent.kind === ts.SyntaxKind.CatchClause); |
There was a problem hiding this comment.
you can simply rename isExcludedConstructor and add this condition to its return statement
There was a problem hiding this comment.
Ehh, I actually prefer the explicitness. But sure.
src/rules/noEmptyRule.ts
Outdated
| const ALLOW_EMPTY_CATCH = "allow-empty-catch"; | ||
|
|
||
| interface Options { | ||
| allowEmptyCatch?: boolean; |
adidahiya
approved these changes
Jun 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Allows catch blocks to be empty.
Fixes #1088.
CHANGELOG.md entry:
[enhancement] Added allow-empty-catch option to
no-empty