Incorrect JSON schema for import-blacklist and variable-name

[ChrisMBarr]

Bug Report

• TSLint version: 5.16.0
• TypeScript version: 3.2.4
• Running TSLint via: (pick one) CLI

with tslint.json configuration:

"import-blacklist": {
    "options": ["rxjs/Rx", {"protractor": ["By"]}]
},
"variable-name": {
    "options": ["ban-keywords", "check-format", "require-const-for-all-caps"]
},

Actual behavior

The VSCode IDE reports that the object syntax for the import-blacklist rule is invalid, and that the "require-const-for-all-caps" option for the variable-name rule is invalid.

Screenshots

Expected behavior

Both of these options are valid, they work just fine. They are taken straight from the documentation page. The JSON schema just needs to be updated to know about these so they don't throw people off when they are trying to configure these rules.

[mirceapop89]

I took a look at this and noticed that for "variable-name" the "require-const-for-all-caps" rule is indeed missing from the JSON schema enum. I will try to make time one of these days for a PR.

That being said, the situation for import-blacklist is different as the JSON schema is supposed to handle the mentioned situation. The problem there seems to be that VSCode is configured to use the JSON Schema Store server (http://schemastore.org/) and the tslint JSON schema is indeed not updated on their server.

Even if someone did update the schema from there I think that the default behavior of VSCode using the JSON Schema Store server is flawed because it doesn't seem to have a versioning concept, which might result in mismatches if breaking changes are introduced in tslint.

There is an alternative to updating the schema on the server, more exactly to define another schema in the VS Code workspace or the VS Code settings files.

More information about VSCode and JSON schemas can be found here.

[adidahiya]

I've fixed up the variable name rule metadata in #4731. We don't maintain the JSON schema in Schema Store here in this repo. As @mirceapop89 mentioned, getting the schema there to match up with the installed version of TSLint is a little out of scope, but if you find a good solution please share here.

[ChrisMBarr]

Looks like the schemastore file for TSLint is on their github page here: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/tslint.json

Looks like people have opened issues with them to update this file for a few various reasons:

• tslint.json outdated: 'no-any' with new option SchemaStore/schemastore#678
• tslint.json outdated : type-literal-delimiter with option 'singleLine' SchemaStore/schemastore#606
• tslint.json esSpecCompliant in "trailing-comma" rule SchemaStore/schemastore#484
• Wrong warnings in tslint.json for accepted configuration values SchemaStore/schemastore#245