Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more JQMIGRATE notices from our jquery upgrade migration #281

Closed
macnewbold opened this issue Aug 2, 2024 · 1 comment · Fixed by #290
Closed

Fix more JQMIGRATE notices from our jquery upgrade migration #281

macnewbold opened this issue Aug 2, 2024 · 1 comment · Fixed by #290

Comments

@macnewbold
Copy link
Contributor

Currently 0.15.1 is throwing some JavaScript warnings from jquery-migrate.js that we should clean up. This probably isn't a complete list, but ones that I've run into so far include:

  • jQuery.trim is deprecated; use String.prototype.trim (from toolbar.js line 2 in $.cookie)
  • jQuery.fn.unbind() is deprecated (from toolbar.js line 146 in hide_toolbar() at $(document).unbind('keydown.flDebug');)

There are also two that are issues within jquery.tablesorter.js so we may want to update to a newer version of that:

  • jQuery.isFunction() is deprecated (line 1029 in buildCache)
  • jQuery.fn.bind() is deprecated (line 484 in bindEvents)

Environment:

  • Flask-DebugToolbar version: 0.15.1
@garinm90
Copy link

Hey, you have any requirements on contributing or can I just clone the repo and issue a PR?
If so, I'll look into updating any deprecated functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants