Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are pull-requests going to be merged? #480

Closed
k-nut opened this issue Jan 5, 2014 · 4 comments
Closed

Are pull-requests going to be merged? #480

k-nut opened this issue Jan 5, 2014 · 4 comments

Comments

@k-nut
Copy link

k-nut commented Jan 5, 2014

I've seen quite a number of pull requests being issued in this repo in the last weeks but none of them have been merged. Are the maintainers just busy or do they need help with something? I feel like some of the pull requests fix rather important bugs and should be merged and published. I'm looking forward to hearing your thoughts on this!

@Mattias-
Copy link

Mattias- commented Jan 5, 2014

👍

@untitaker
Copy link
Contributor

From pallets/jinja#283 (comment)

Sorry for not handling this for so long. I'm trying to fix this. For the time being, send me an email if you have any more requests that need proper review to jump ahead of the github notification list.

@mitsuhiko's been busy since i got involved in this project, which is, i think, a little less than a year now. Apart from him, i think only @DasIch and @kennethreitz have the rights to merge things, but Armin does have the last say, which is a good thing for code quality, but not for the activity of the development around Flask and Werkzeug.

@kennethreitz
Copy link
Contributor

Pull Requests are, unfortunately, the enemy of stable software.

@untitaker
Copy link
Contributor

That sounds like a nice catchphrase, but IMO Werkzeug lost the stable status it used to have before the Python 3 port got merged into master.

@DasIch DasIch closed this as completed Mar 21, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants