Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create .npmignore #115

Closed
wants to merge 1 commit into from
Closed

Create .npmignore #115

wants to merge 1 commit into from

Conversation

huchenme
Copy link

This does not resolve #105 but could prevent yarn-error.log get added in accidentally in future

@TrySound
Copy link
Collaborator

yarn-error.log is never published in tsdx package.
https://github.com/palmerhq/tsdx/blob/master/package.json#L28-L31

You need to add files to generated package.json.

@huchenme
Copy link
Author

hmm, it got published in current version and the file is in templates folder

@TrySound
Copy link
Collaborator

I see. It's because templates is included to files. Then this solution is probably ok. Will think more.

@huchenme huchenme mentioned this pull request May 30, 2019
Closed
@jaredpalmer
Copy link
Owner

This was fixed in the latest release

@huchenme huchenme deleted the patch-2 branch May 30, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New project includes yarn-error.log
3 participants
@huchenme @TrySound @jaredpalmer