Skip to content

Commit 00b10db

Browse files
committed
convert_datetime64 defaults to True if not passed
1 parent 4b28b4d commit 00b10db

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

pandas/core/frame.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1204,7 +1204,7 @@ def to_records(self, index=True, convert_datetime64=None):
12041204
----------
12051205
index : boolean, default True
12061206
Include index in resulting record array, stored in 'index' field
1207-
convert_datetime64 : boolean, optional
1207+
convert_datetime64 : boolean, default True
12081208
.. deprecated:: 0.23.0
12091209
12101210
Whether to convert the index to datetime.datetime if it is a
@@ -1220,6 +1220,8 @@ def to_records(self, index=True, convert_datetime64=None):
12201220
"deprecated and will be removed in a future "
12211221
"version",
12221222
FutureWarning, stacklevel=2)
1223+
else:
1224+
convert_datetime64 = True
12231225

12241226
if index:
12251227
if is_datetime64_any_dtype(self.index) and convert_datetime64:

pandas/tests/frame/test_convert_to.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,17 @@ def test_to_records_dt64(self):
7878
df = DataFrame([["one", "two", "three"],
7979
["four", "five", "six"]],
8080
index=date_range("2012-01-01", "2012-01-02"))
81+
8182
with tm.assert_produces_warning(FutureWarning):
8283
expected = df.index[0]
8384
result = df.to_records(convert_datetime64=True)['index'][0]
8485
assert expected == result
8586

87+
expected = df.index[0]
88+
# convert_datetime64 defaults to True if not passed
89+
result = df.to_records()['index'][0]
90+
assert expected == result
91+
8692
with tm.assert_produces_warning(FutureWarning):
8793
rs = df.to_records(convert_datetime64=False)
8894
assert rs['index'][0] == df.index.values[0]

0 commit comments

Comments
 (0)