Skip to content

Commit 11c26e2

Browse files
committed
BUG: value_counts not working correctly on ExtensionArrays
1 parent 3d4f9dc commit 11c26e2

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

pandas/core/algorithms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -724,7 +724,7 @@ def value_counts(
724724
result = result.sort_values(ascending=ascending)
725725

726726
if normalize:
727-
result = result / float(counts.sum())
727+
result = result / float(sum(counts))
728728

729729
return result
730730

pandas/tests/arrays/string_/test_string.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,3 +277,13 @@ def test_value_counts_na():
277277
result = arr.value_counts(dropna=True)
278278
expected = pd.Series([2, 1], index=["a", "b"], dtype="Int64")
279279
tm.assert_series_equal(result, expected)
280+
281+
282+
def test_normalize_value_counts():
283+
result = (
284+
pd.Series(list("abcd"), dtype="string")
285+
.value_counts(normalize=True)
286+
.sort_index()
287+
)
288+
expected = pd.Series([0.25, 0.25, 0.25, 0.25], index=["a", "b", "c", "d"])
289+
tm.assert_series_equal(expected, result)

0 commit comments

Comments
 (0)