Skip to content

Commit 31b7464

Browse files
committed
Merge pull request #10659 from chris-b1/rolling-name
BUG: #10565 Series.name lost in rolling_* funcions
2 parents ed13da0 + b298492 commit 31b7464

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

doc/source/whatsnew/v0.17.0.txt

+1-2
Original file line numberDiff line numberDiff line change
@@ -348,8 +348,7 @@ Bug Fixes
348348
- Bug in ``ExcelReader`` when worksheet is empty (:issue:`6403`)
349349
- Bug in ``Table.select_column`` where name is not preserved (:issue:`10392`)
350350
- Bug in ``offsets.generate_range`` where ``start`` and ``end`` have finer precision than ``offset`` (:issue:`9907`)
351-
352-
351+
- Bug in ``pd.rolling_*`` where ``Series.name`` would be lost in the output (:issue:`10565`)
353352

354353

355354

pandas/stats/moments.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ def _process_data_structure(arg, kill_inf=True):
426426
values = arg.values
427427
elif isinstance(arg, Series):
428428
values = arg.values
429-
return_hook = lambda v: Series(v, arg.index)
429+
return_hook = lambda v: Series(v, arg.index, name=arg.name)
430430
else:
431431
return_hook = lambda v: v
432432
values = arg

pandas/stats/tests/test_moments.py

+8
Original file line numberDiff line numberDiff line change
@@ -725,6 +725,14 @@ def test_ewma_halflife_arg(self):
725725
self.assertRaises(Exception, mom.ewma, self.arr, com=9.5, span=20, halflife=50)
726726
self.assertRaises(Exception, mom.ewma, self.arr)
727727

728+
def test_moment_preserve_series_name(self):
729+
# GH 10565
730+
s = Series(np.arange(100), name='foo')
731+
s2 = mom.rolling_mean(s, 30)
732+
s3 = mom.rolling_sum(s, 20)
733+
self.assertEqual(s2.name, 'foo')
734+
self.assertEqual(s3.name, 'foo')
735+
728736
def test_ew_empty_arrays(self):
729737
arr = np.array([], dtype=np.float64)
730738

0 commit comments

Comments
 (0)