simplify concat

Author: jreback

pandas/core/dtypes/concat.py

@@ -432,6 +432,12 @@ def _concat_datetime(to_concat, axis=0, typs=None):
     a single array, preserving the combined dtypes
     """
 
+    def concatenate(to_concat, axis):
+        # coerce to 2d if needed & concatenate
+        if axis == 1:
+            to_concat = [np.atleast_2d(x) for x in to_concat]
+        return np.concatenate(to_concat, axis=axis)
+
     def convert_to_pydatetime(x, axis):
         # coerce to an object dtype
 
@@ -450,8 +456,6 @@ def convert_to_pydatetime(x, axis):
             x = tslib.ints_to_pytimedelta(x.view(np.int64).ravel(), box=True)
             x = x.reshape(shape)
 
-        if axis == 1:
-            x = np.atleast_2d(x)
         return x
 
     if typs is None:
@@ -467,20 +471,15 @@ def convert_to_pydatetime(x, axis):
             if 'datetime' in typs:
                 to_concat = [np.array(x, copy=False).view(np.int64)
                              for x in to_concat]
-                if axis == 1:
-                    to_concat = [np.atleast_2d(x) for x in to_concat]
-
-                new_values = np.concatenate(to_concat, axis=axis)
-                return new_values.view(_NS_DTYPE)
+                return concatenate(to_concat, axis=axis).view(_NS_DTYPE)
             else:
                 # when to_concat has different tz, len(typs) > 1.
                 # thus no need to care
                 return _concat_datetimetz(to_concat)
 
         elif 'timedelta' in typs:
-            new_values = np.concatenate([x.view(np.int64) for x in to_concat],
-                                        axis=axis)
-            return new_values.view(_TD_DTYPE)
+            return concatenate([x.view(np.int64) for x in to_concat],
+                               axis=axis).view(_TD_DTYPE)
 
         elif _contains_period:
             # PeriodIndex must be handled by PeriodIndex,
@@ -489,8 +488,8 @@ def convert_to_pydatetime(x, axis):
             raise NotImplementedError
 
     # need to coerce to object
-    to_concat = [convert_to_pydatetime(x, axis) for x in to_concat]
-    return np.concatenate(to_concat, axis=axis)
+    return concatenate([convert_to_pydatetime(x, axis) for x in to_concat],
+                       axis=axis)
 
 
 def _concat_datetimetz(to_concat, name=None):