PERF: Checking for length of categories before doing string conversion. fixes #11305

Author: michaelaye

asv_bench/benchmarks/categoricals.py

@@ -1,6 +1,7 @@
 from .pandas_vb_common import *
 import string
 
+
 class concat_categorical(object):
     goal_time = 0.2
 
@@ -26,6 +27,7 @@ def time_value_counts(self):
     def time_value_counts_dropna(self):
         self.ts.value_counts(dropna=True)
 
+
 class categorical_constructor(object):
     goal_time = 0.2
 
@@ -43,3 +45,16 @@ def time_regular_constructor(self):
     def time_fastpath(self):
         Categorical(self.codes, self.cat_idx, fastpath=True)
 
+
+class categorical_rendering(object):
+    goal_time = 3e-3
+
+    def setup(self):
+        n = 1000
+        items = [str(i) for i in range(n)]
+        s = pd.Series(items, dtype='category')
+        df = pd.DataFrame({'C': s, 'data': np.random.randn(n)})
+        self.data = df[df.C == '20']
+
+    def time_rendering(self):
+        str(self.data.C)

doc/source/whatsnew/v0.17.1.txt

@@ -3,7 +3,7 @@
 v0.17.1 (November ??, 2015)
 ---------------------------
 
-This is a minor bug-fix release from 0.17.0 and includes a a large number of
+This is a minor bug-fix release from 0.17.0 and includes a large number of
 bug fixes along several new features, enhancements, and performance improvements.
 We recommend that all users upgrade to this version.
 
@@ -64,9 +64,11 @@ Performance Improvements
 - Improved performance of ``rolling_median`` (:issue:`11450`)
 
 - Improved performance to ``to_excel`` (:issue:`11352`)
+- Performance bug in repr of ``Categorical`` categories, which was rendering the strings before chopping them for display (:issue:`11305`)
 
 .. _whatsnew_0171.bug_fixes:
 
+
 Bug Fixes
 ~~~~~~~~~
 

pandas/core/categorical.py

@@ -1390,12 +1390,13 @@ def _repr_categories(self):
         max_categories = (10 if get_option("display.max_categories") == 0
                     else get_option("display.max_categories"))
         from pandas.core import format as fmt
-        category_strs = fmt.format_array(self.categories, None)
-        if len(category_strs) > max_categories:
+        if len(self.categories) > max_categories:
             num = max_categories // 2
-            head = category_strs[:num]
-            tail = category_strs[-(max_categories - num):]
+            head = fmt.format_array(self.categories[:num], None)
+            tail = fmt.format_array(self.categories[-num:], None)
             category_strs = head + ["..."] + tail
+        else:
+            category_strs = fmt.format_array(self.categories, None)
 
         # Strip all leading spaces, which format_array adds for columns...
         category_strs = [x.strip() for x in category_strs]