define pd_array in construction

Author: MarcoGorelli

pandas/core/algorithms.py

@@ -84,9 +84,9 @@
 
 from pandas.core.array_algos.take import take_nd
 from pandas.core.construction import (
-    array as pd_array,
     ensure_wrapped_if_datetimelike,
     extract_array,
+    pd_array,
 )
 from pandas.core.indexers import validate_indices
 

pandas/core/api.py

@@ -43,7 +43,7 @@
     UInt64Dtype,
 )
 from pandas.core.arrays.string_ import StringDtype
-from pandas.core.construction import array
+from pandas.core.construction import pd_array as array
 from pandas.core.flags import Flags
 from pandas.core.groupby import (
     Grouper,

pandas/core/apply.py

@@ -52,8 +52,8 @@
 )
 import pandas.core.common as com
 from pandas.core.construction import (
-    array as pd_array,
     create_series_with_explicit_dtype,
+    pd_array,
 )
 
 if TYPE_CHECKING:

pandas/core/arrays/categorical.py

@@ -97,8 +97,8 @@
 )
 import pandas.core.common as com
 from pandas.core.construction import (
-    array as pd_array,
     extract_array,
+    pd_array,
     sanitize_array,
 )
 from pandas.core.indexers import deprecate_ndim_indexing

pandas/core/arrays/datetimelike.py

@@ -107,8 +107,8 @@
 )
 import pandas.core.common as com
 from pandas.core.construction import (
-    array as pd_array,
     extract_array,
+    pd_array,
 )
 from pandas.core.indexers import (
     check_array_indexer,

pandas/core/arrays/interval.py

@@ -76,9 +76,9 @@
 from pandas.core.arrays.categorical import Categorical
 import pandas.core.common as com
 from pandas.core.construction import (
-    array as pd_array,
     ensure_wrapped_if_datetimelike,
     extract_array,
+    pd_array,
 )
 from pandas.core.indexers import check_array_indexer
 from pandas.core.indexes.base import ensure_index

pandas/core/construction.py

@@ -74,7 +74,7 @@
     )
 
 
-def array(
+def pd_array(
     data: Union[Sequence[object], AnyArrayLike],
     dtype: Optional[Dtype] = None,
     copy: bool = True,
@@ -560,7 +560,7 @@ def sanitize_array(
         if is_object_dtype(subarr.dtype) and not is_object_or_str_dtype:
             inferred = lib.infer_dtype(subarr, skipna=False)
             if inferred in {"interval", "period"}:
-                subarr = array(subarr)
+                subarr = pd_array(subarr)
                 subarr = extract_array(subarr, extract_numpy=True)
 
     return subarr

pandas/core/dtypes/concat.py

@@ -25,8 +25,8 @@
 from pandas.core.arrays import ExtensionArray
 from pandas.core.arrays.sparse import SparseArray
 from pandas.core.construction import (
-    array as pd_array,
     ensure_wrapped_if_datetimelike,
+    pd_array,
 )
 
 

pandas/core/indexers.py

@@ -514,7 +514,7 @@ def check_array_indexer(array: AnyArrayLike, indexer: Any) -> Any:
     ...
     IndexError: arrays used as indices must be of integer or boolean type
     """
-    from pandas.core.construction import array as pd_array
+    from pandas.core.construction import pd_array
 
     # whatever is not an array-like is returned as-is (possible valid array
     # indexers that are not array-like: integer, slice, Ellipsis, None)

pandas/core/indexing.py

@@ -48,7 +48,7 @@
 )
 
 import pandas.core.common as com
-from pandas.core.construction import array as pd_array
+from pandas.core.construction import pd_array
 from pandas.core.indexers import (
     check_array_indexer,
     is_exact_shape_match,

pandas/core/strings/accessor.py

@@ -3021,10 +3021,8 @@ def _str_extract_noexpand(arr, pat, flags=0):
     Index.
 
     """
-    from pandas import (
-        DataFrame,
-        array as pd_array,
-    )
+    from pandas import DataFrame
+    from pandas.core.construction import pd_array
 
     regex = re.compile(pat, flags=flags)
     groups_or_na = _groups_or_na_fun(regex)

scripts/tests/test_use_pd_array_in_core.py

@@ -2,25 +2,24 @@
 
 from scripts.use_pd_array_in_core import use_pd_array
 
-BAD_FILE_0 = "import pandas as pd\npd.array"
-BAD_FILE_1 = "\nfrom pandas import array"
-GOOD_FILE_0 = "from pandas import array as pd_array"
-GOOD_FILE_1 = "from pandas.core.construction import array as pd_array"
+BAD_FILE_0 = "\nfrom pandas import array as pd_array"
+BAD_FILE_1 = "import pandas as pd\npd.array"
+GOOD_FILE = "from pandas.core.construction import pd_array"
 PATH = "t.py"
 
 
 @pytest.mark.parametrize("content", [BAD_FILE_0, BAD_FILE_1])
 def test_inconsistent_usage(content, capsys):
     result_msg = (
-        r"t.py:2:0: Don't use pd.array in core, import array as pd_array instead\n"
+        "t.py:2:0: Don't use pd.array in core, "
+        "instead use 'from pandas.core.construction import pd_array'\n"
     )
     with pytest.raises(SystemExit):
         use_pd_array(content, PATH)
     expected_msg, _ = capsys.readouterr()
     assert result_msg == expected_msg
 
 
-@pytest.mark.parametrize("content", [GOOD_FILE_0, GOOD_FILE_1])
-def test_consistent_usage(content):
+def test_consistent_usage():
     # should not raise
-    use_pd_array(content, PATH)
+    use_pd_array(GOOD_FILE, PATH)

scripts/use_pd_array_in_core.py

@@ -1,7 +1,8 @@
 """
-Check that pandas/core imports pandas.array as pd_array.
+Check files use pd_array from pandas.core.construction rather than pd.array.
 
-This makes it easier to grep for usage of pandas array.
+This is only run within pandas/core and makes it easier to grep for usage of
+pandas array.
 
 This is meant to be run as a pre-commit hook - to run it manually, you can do:
 
@@ -19,7 +20,8 @@
 
 ERROR_MESSAGE = (
     "{path}:{lineno}:{col_offset}: "
-    "Don't use pd.array in core, import array as pd_array instead\n"
+    "Don't use pd.array in core, instead use "
+    "'from pandas.core.construction import pd_array'\n"
 )
 
 
@@ -33,7 +35,7 @@ def visit_ImportFrom(self, node: ast.ImportFrom) -> None:
         if (
             node.module is not None
             and node.module.startswith("pandas")
-            and any(i.name == "array" and i.asname != "pd_array" for i in node.names)
+            and any(i.name == "array" for i in node.names)
         ):
             msg = ERROR_MESSAGE.format(
                 path=self.path, lineno=node.lineno, col_offset=node.col_offset