Skip to content

Commit c3d5f22

Browse files
committed
Parametrize test_min_max_skipna in reductions/test_reductions.py
1 parent 5fb0ab3 commit c3d5f22

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

pandas/tests/reductions/test_reductions.py

+10-10
Original file line numberDiff line numberDiff line change
@@ -1041,21 +1041,21 @@ def test_min_max(self):
10411041
assert _min == 2
10421042
assert _max == 1
10431043

1044-
def test_min_max_skipna(self):
1044+
@pytest.mark.parametrize("skipna", [True, False])
1045+
def test_min_max_skipna(self, skipna):
10451046
# GH 25303
10461047
cat = Series(
10471048
Categorical(["a", "b", np.nan, "a"], categories=["b", "a"], ordered=True)
10481049
)
1050+
_min = cat.min(skipna=skipna)
1051+
_max = cat.max(skipna=skipna)
10491052

1050-
_min = cat.min()
1051-
_max = cat.max()
1052-
assert _min == "b"
1053-
assert _max == "a"
1054-
1055-
_min = cat.min(skipna=False)
1056-
_max = cat.max(skipna=False)
1057-
assert np.isnan(_min)
1058-
assert np.isnan(_max)
1053+
if skipna is True:
1054+
assert _min == "b"
1055+
assert _max == "a"
1056+
else:
1057+
assert np.isnan(_min)
1058+
assert np.isnan(_max)
10591059

10601060

10611061
class TestSeriesMode:

0 commit comments

Comments
 (0)