Skip to content

Commit d6f29f4

Browse files
author
Alex
committed
Deprecate positional match argument for read_html, update whatsnew.
1 parent 56a4128 commit d6f29f4

File tree

4 files changed

+9
-16
lines changed

4 files changed

+9
-16
lines changed

doc/source/whatsnew/v0.25.1.rst

-12
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,6 @@
77
What's new in 0.25.1 (July XX, 2019)
88
------------------------------------
99

10-
.. warning::
11-
12-
Starting with the version 0.25.1, :func:`read_html` function
13-
should get all its arguments but `io` and `match` as keyword
14-
keyword only.
15-
16-
.. warning::
17-
18-
Starting with the version 0.25.1, :func:`read_json` function
19-
should get all its arguments but `path_or_buf` as keyword
20-
arguments only.
21-
2210
Enhancements
2311
~~~~~~~~~~~~
2412

doc/source/whatsnew/v1.0.0.rst

+7-2
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,13 @@ Other API changes
5353
Deprecations
5454
~~~~~~~~~~~~
5555

56-
-
57-
-
56+
- Passing any arguments but `io` to :func:`read_html` as positional
57+
arguments is deprecated since version 1.0. All other arguments should
58+
be given as keyword arguments.
59+
60+
- Passing any arguments but `path_or_buf` to :func:`read_json` as positional
61+
arguments is deprecated since version 1.0. All other arguments should
62+
be given as keyword arguments.
5863

5964
.. _whatsnew_1000.prior_deprecations:
6065

pandas/io/html.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -921,7 +921,7 @@ def _parse(flavor, io, match, attrs, encoding, displayed_only, **kwargs):
921921
return ret
922922

923923

924-
@deprecate_nonkeyword_arguments(version="1.0", allowed_args=["io", "match"])
924+
@deprecate_nonkeyword_arguments(version="1.1", allowed_args=["io"])
925925
def read_html(
926926
io,
927927
match=".+",

pandas/io/json/_json.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ def _write(
332332
return serialized
333333

334334

335-
@deprecate_nonkeyword_arguments(version="1.0", allowed_args=["path_or_buf"])
335+
@deprecate_nonkeyword_arguments(version="1.1", allowed_args=["path_or_buf"])
336336
def read_json(
337337
path_or_buf=None,
338338
orient=None,

0 commit comments

Comments
 (0)