Skip to content

DTA/TDI init methods #24684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Jan 9, 2019 · 1 comment
Closed

DTA/TDI init methods #24684

TomAugspurger opened this issue Jan 9, 2019 · 1 comment
Labels
Datetime Datetime data dtype

Comments

@TomAugspurger
Copy link
Contributor

(placeholder for now. will fill in later.)

These methods are starting to use sequence_to_td/dt64ns, which makes them parse strings, which some of use don't want. Those methods also do redundant type checking, which induces overhead over our ideal of a simple init.

xref #24666 and the DTA issue I'll add later.

Not a blocker for the RC.
@TomAugspurger TomAugspurger added the Datetime Datetime data dtype label Jan 9, 2019
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Jan 9, 2019
This was referenced Jan 9, 2019
Merged
Merged
@jreback jreback modified the milestones: 0.24.0, 0.25.0 Jan 21, 2019
@TomAugspurger
Copy link
Contributor Author

(placeholder for now. will fill in later.)

This issue isn't clear to me now. Closing.

@TomAugspurger TomAugspurger modified the milestones: 0.25.0, No action Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Datetime Datetime data dtype
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jreback @TomAugspurger