Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for EA Series Operations Support #26913

Closed
ghost opened this issue Jun 18, 2019 · 4 comments
Closed

Tracking issue for EA Series Operations Support #26913

ghost opened this issue Jun 18, 2019 · 4 comments
Labels
ExtensionArray Extending pandas with custom dtypes or arrays.

Comments

@ghost
Copy link

ghost commented Jun 18, 2019

Stale

@simonjayhawkins simonjayhawkins added the ExtensionArray Extending pandas with custom dtypes or arrays. label Jun 18, 2019
@jorisvandenbossche
Copy link
Member

Series.isna which (via pd.core.dtypes.missing._isna_new) , calls np.asarray(obj). This is contrary to documentation which says:

This should not be the case (if it is, it is a bug that should be fixed). _isna_new calls the isna method on the object through _isna_ndarraylike

@ghost
Copy link
Author

ghost commented Jun 19, 2019

You're right. I don't know what happened, but I tested this again now and the method is called. Perhaps I was testing while I had an __array_function__ implemented in the EA.

Anyway, my mistake. sorry.

@jorisvandenbossche
Copy link
Member

Perhaps I was testing while I had an array_function implemented in the EA.

If that is the case, it was not your mistake, and it would be interesting to know. Because the isna machinery should work regardless of having __array_function__ defined or not.

@ghost ghost changed the title Tracking issue for supporting various Series operations on EA Tracking issue for EA Series Operations Support Jun 25, 2019
@ghost ghost closed this as completed Jun 28, 2019
@simonjayhawkins
Copy link
Member

@jorisvandenbossche closing as with the OP deleted this issue does not appear actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

No branches or pull requests

2 participants