Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC/TST: provide documentation & testing on groupby filtering & aggregation ops for EA #27078

Closed
jreback opened this issue Jun 27, 2019 · 2 comments
Closed

DOC/TST: provide documentation & testing on groupby filtering & aggregation ops for EA #27078

jreback opened this issue Jun 27, 2019 · 2 comments
Labels
Categorical Categorical Data Type Docs ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite

Comments

@jreback
Copy link
Contributor

jreback commented Jun 27, 2019

#27071 allows for the preservation dtype for filtering type of ops in groupby (first, last, min, max). This should work for all EA (though was fixing Categorical).

We should

  • test all EA more generally for groupby filtering type ops & potentially other aggregations
  • document what works / what doesn't work.
@jreback jreback added Testing pandas testing functions or related to the test suite Docs Categorical Categorical Data Type ExtensionArray Extending pandas with custom dtypes or arrays. labels Jun 27, 2019
@jreback jreback added this to the Contributions Welcome milestone Jun 27, 2019
@jreback jreback mentioned this issue Jun 27, 2019
Merged
@kidrahahjo
Copy link

@jreback will it be okay to close this issue? Or some work is required to be done here?

@jreback
Copy link
Contributor Author

jreback commented Jan 27, 2021

yep i think this is good

@jreback jreback modified the milestones: Contributions Welcome, No action Jan 27, 2021
@jreback jreback closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Categorical Categorical Data Type Docs ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jreback @kidrahahjo