Skip to content

Performance regression in reindex.LevelAlign.time_reindex_level #35804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Aug 19, 2020 · 4 comments · Fixed by #38560
Closed

Performance regression in reindex.LevelAlign.time_reindex_level #35804

TomAugspurger opened this issue Aug 19, 2020 · 4 comments · Fixed by #38560
Assignees
@simonjayhawkins
Labels
Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Milestone
1.2

Comments

@TomAugspurger
Copy link
Contributor

https://pandas.pydata.org/speed/pandas/index.html#reindex.LevelAlign.time_reindex_level?commits=a0c8425a5f2b74e8a716defd799c4a3716f66eff-2a319238e47d3d7362188f7da4eb911199c423b8

Somewhere in a0c8425...2a31923
@TomAugspurger TomAugspurger added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 19, 2020
@dsaxton
Copy link
Member

dsaxton commented Aug 19, 2020

0b90685 seems to be the only commit in that range that touches index code. May be worth investigating @simonjayhawkins?

@jorisvandenbossche jorisvandenbossche added Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 20, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.2 milestone Aug 20, 2020
@jorisvandenbossche
Copy link
Member

I suppose #35805 might be related to the same then?

@simonjayhawkins
Copy link
Member

Thanks @dsaxton will look soon

@simonjayhawkins simonjayhawkins self-assigned this Aug 20, 2020
@jreback jreback modified the milestones: 1.2, Contributions Welcome Nov 28, 2020
@jreback
Copy link
Contributor

jreback commented Nov 28, 2020

no open PR for this, moving off 1.2

@simonjayhawkins simonjayhawkins mentioned this issue Nov 30, 2020
Closed
@simonjayhawkins simonjayhawkins mentioned this issue Dec 18, 2020
Merged
6 tasks
@jreback jreback modified the milestones: Contributions Welcome, 1.2 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonjayhawkins simonjayhawkins

Labels
Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.2
5 participants
@jreback @jorisvandenbossche @TomAugspurger @dsaxton @simonjayhawkins