-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CLN: Add typing for dtype argument in codebase #38808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Add typing for io/parsers.py, io/excel/_base.py, io/json/_json.py and io/pytables.py in 38814 Add typing for core/arrays/datetimelike.py, core/arrays/base.py, core/arrays/boolean.py, core/arrays/categorical.py and core/arrays/integer.py in 38826 |
I would like to work on a few files, would it be possible? |
Sure, go ahead! Would propose to take a number of files (max 5 or less) and start with them. Please first mention the files here such that other people will not work on those files. |
I will work on the remainder of files in the directory |
I will work on all the files in the directory |
Good to hear! Once you've started, it would be great if you could reference this issue in the PR that will update core/frame.py |
Hi, I would like to work on |
Thanks @tushushu, will mark that file as done. |
Will work on the dir |
Anyone working on ```
|
Sorry @zbremmer, all the files that need to be modified according to this issue are already taken or finished. But please have a look at other issues, since there are still plenty of open issues! |
@rbpatt2019 any updates on |
Follow up from #37546 and #38680
Add typing for the
dtype
argument throughout the pandas codebase. Part of the code might need an update after adding the type since the mypy type checks can fail.In #38680 it is already done for
io/sql.py
, from a directory search I found that the list of files below still have untyped dtype arguments.Would be great if people can work on a few files at a time in separate PRs and mention this issue. I will already start with the remaining files in the io directory
The text was updated successfully, but these errors were encountered: