TYP: overriding of final methods

[twoertwein]

pyright says that a few methods that are marked with typing.Final are overridden:

pandas/core/frame.py:4552:9 - error: Method "_reindex_axes" cannot override final method defined in class "NDFrame"
pandas/core/frame.py:10727:9 - error: Method "mask" cannot override final method defined in class "NDFrame"
pandas/core/series.py:5446:9 - error: Method "mask" cannot override final method defined in class "NDFrame"
pandas/core/groupby/generic.py:676:9 - error: Method "describe" cannot override final method defined in class "GroupBy"
pandas/core/groupby/generic.py:856:9 - error: Method "pct_change" cannot override final method defined in class "GroupBy"

[jbrockmendel]

why isn't mypy catching these?

[simonjayhawkins]

why isn't mypy catching these?

see python/mypy#9618

if indeed we add types to _reindex_axes in pandas/core/frame.py we get pandas/core/frame.py:4552: error: Cannot override final attribute "_reindex_axes" (previously declared in base class "NDFrame") [misc]

[twoertwein]

I think this has quietly been fixed :)