Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Generalize GA to work with MCF API #4919

Closed
tshauck opened this issue Sep 21, 2013 · 4 comments
Closed

ENH: Generalize GA to work with MCF API #4919

tshauck opened this issue Sep 21, 2013 · 4 comments

Comments

@tshauck
Copy link
Contributor

tshauck commented Sep 21, 2013

Right now the Google Analytics functionality is too specific to the Core Reporting API. It should be generalized to handle MultiChannel Attribution as well.

For example,

def _get_col_names(header_info):
    return [x['name'][3:] for x in header_info]

Would break because headers in are prepended with mcf: in the MultiChannel Attribution API.

@jreback
Copy link
Contributor

jreback commented Feb 16, 2014

@tshauck if you are interested in working on this, ok? but can you explain the usecase a bit more and where you think ga should be going?

@tshauck
Copy link
Contributor Author

tshauck commented Feb 17, 2014

@jreback My thought is that Google Analytics actually has several APIs: Core Reporting (currently the only one implemented), MultiChannel Attribution, MultiChannel Interaction, and Management; so it would nice to have access the rest of the data as well.

The issue right now, is that the way some of the helper functions are implemented they're too specific to the Core Reporting API and won't generalize. I.e. if _get_col_names was implemented as

def _get_col_names(header_info):
    return [x.split()[1] for x in header_info]

The ga module would be in a better position to handle more GA APIs w/ the same code.

@jreback
Copy link
Contributor

jreback commented Feb 17, 2014

@tshauck ok.....pls put together something (if you want able), on how you think the GA infrastructure should be changed going forward. Their are several open issues relating to GA (filter on the Google I/O label which also includes BigQuery, so that's separate).

@jreback jreback modified the milestones: 0.15.0, 0.14.0 Mar 28, 2014
@jreback jreback modified the milestones: 0.16.0, Someday Mar 3, 2015
@jreback
Copy link
Contributor

jreback commented Oct 14, 2015

closing as deprecating ga in #11308

@jreback jreback closed this as completed Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants