STYLE: Add ruff check to avoid multiple with statements

[DeaMariaLeon]

Currently, it is possible to nest multiple consecutive context managers in the code.
It can be avoided by adding the following to ruff checks:

https://beta.ruff.rs/docs/rules/multiple-with-statements/

This should be added to .pre-commit-config.yaml

[snorfyang]

Maybe in pyproject.toml?

[DeaMariaLeon]

Thank you for telling me @snorfyang. Since I'm not sure, I'm tagging @MarcoGorelli.

[MarcoGorelli]

yup, that's right, along with the other ruff codes - PRs welcome if this interests anyone! if you add the code for this check to pyproject.toml, and then can get pre-commit run ruff --all-files to pass, then you've done this correctly

[snorfyang]

take

[phofl]

Maybe a stupid question, but why would we want to disallow this globally? 2 with statements might have different scope

[DeaMariaLeon]

It would still be possible to have two or more scopes, it is just the way to write them that would change. Look at Marco's comment here if you wish.
He avoids writing with twice but he is still managing the warning and the error.

[phofl]

They might refer to different Code parts though, not all with statements might exactly have the same length.

[MarcoGorelli]

I presume ruff has thought about this and they only recommend collapsing the 'with' statements if they have the same scope - should be fine, and it's one of the autofixable ones

[phofl]

I still have concerns about readability, imo we should at least escape tests from this, since this reads terrible, I highlighted one such occurrence in the pr that is linked here

[MarcoGorelli]

it's a matter of preference I guess, if you don't like it then let's leave this one out, no worries, we don't need to enable all of ruff's checks 😃 let's close then, thanks all for the issue/discussion