Skip to content

DOC: Add NAType and NaTType references in docs for pandas.api.typing #54028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Dr-Irv opened this issue Jul 6, 2023 · 2 comments · Fixed by #54448
Closed

DOC: Add NAType and NaTType references in docs for pandas.api.typing #54028

Dr-Irv opened this issue Jul 6, 2023 · 2 comments · Fixed by #54448
Assignees
@omar-elbaz
Labels
Docs
Milestone
2.0.4

Comments

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Jul 6, 2023

In #53934 I suggested we move NAType and NaTType into pandas.api.typing, which was done in #53958 .

But the PR did not include a docs update.

I think it would be worthwhile to add a sentence or two to https://pandas.pydata.org/docs/dev/user_guide/missing_data.html to describe these new public types and their purpose.
@phofl phofl added the Docs label Jul 7, 2023
@oluwatonio
Copy link

take

@oluwatonio oluwatonio removed their assignment Jul 19, 2023
@omar-elbaz
Copy link
Contributor

take

@omar-elbaz omar-elbaz mentioned this issue Jul 24, 2023
Closed
1 task
@omar-elbaz omar-elbaz mentioned this issue Aug 7, 2023
Merged
@jreback jreback added this to the 2.0.4 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omar-elbaz omar-elbaz

Labels
Docs
Projects
None yet
Milestone
2.0.4
5 participants
@jreback @Dr-Irv @phofl @oluwatonio @omar-elbaz