Skip to content

Improve testing coverage #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Feb 4, 2014 · 10 comments
Closed

Improve testing coverage #6251

ghost opened this issue Feb 4, 2014 · 10 comments
Labels
good first issue Testing pandas testing functions or related to the test suite

Comments

@ghost
Copy link

ghost commented Feb 4, 2014

Pandas coverage is currently at 78%, not bad but could be better.
Open issue for first-time contributors: find some ill-tested corner
and bring it into the light.

@KTAtkinson
Copy link

Do you have a document that tracks testing coverage? If not would producing such a document/wiki be helpful?

@jreback
Copy link
Contributor

jreback commented Feb 11, 2014

their is some code for using the coverage package to measure this

would appreciate a section / how to on the wiki though

it's possible need some more / better exhorting to make this more user friendly

pls experiment and let us know

@KTAtkinson
Copy link

So you mainly look at code coverage? Within your testing is there any concept of test flows or test cases? Tests that are larger than unit tests, which is all I've really encountered.

@jorisvandenbossche
Copy link
Member

Would there be interest to use coveralls to track testing coverage? That would be a handy way to see how coverage is for the different modules, and to see where more work is needed.

Example: https://coveralls.io/files/196422109
(based on this commit: jorisvandenbossche@237d784)

You have also the possibility to let coveralls comment on PRs, but I find that sometimes a bit too much (eg see PRs of scipy https://github.com/scipy/scipy/pulls).

@hayd
Copy link
Contributor

hayd commented Sep 4, 2014

@jorisvandenbossche IMO coveralls would be great! Does this slow down the build much?

@jreback
Copy link
Contributor

jreback commented Feb 12, 2016

should be pretty straightforward to add this as @jorisvandenbossche PR almost there.

any takers?

I can turn on the github service so we get notifications of this.

@gliptak
Copy link
Contributor

gliptak commented Mar 26, 2016

@jreback Was coveralls enabled? I see codecov but not coveralls in .travis.yml

There also doesn't seem to be https://coveralls.io/github/pydata/pandas?branch=master

@jreback
Copy link
Contributor

jreback commented Mar 26, 2016

no why would we need more than one?

@gliptak
Copy link
Contributor

gliptak commented Mar 26, 2016

They offer a bit different organization of the same coverage data, so we do not need to have both ...

@jreback jreback modified the milestones: 0.18.1, 0.18.2 Apr 26, 2016
@jreback jreback modified the milestones: 0.18.2, Next Major Release Jul 6, 2016
@mroeschke
Copy link
Member

We have coverage tools installed and coverage it up to 91%. Respectable progress for now; closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

7 participants