adding rtd translator

[choldgraf]

Adding a readthedocs translator for sites that build on RTD.

I'm not sure how to test this other than to see whether it looks correct on readthedocs... @jorisvandenbossche are you OK with a merge and spot-check afterwards?

The fix was inspired by comments here: readthedocs/readthedocs.org#6690

[jorisvandenbossche]

@choldgraf yes, fine with just merging and relying on other projects using it as "test".

But, can you also add the additional builder as done here: https://github.com/readthedocs/sphinx-hoverxref/blob/master/hoverxref/extension.py#L116 ("readthedocsdirhtml", I think that is for if you enable a "download html" version), and also add a comment explaining it briefly (or pointing to the issue)?

[choldgraf]

ok cool - just added them both, let's see if RTD builds it

[choldgraf]

looks good to me! https://pandas-sphinx-theme.readthedocs.io/en/latest/demo/demo.html#admonitions

[jorisvandenbossche]

Thanks!

[humitos]

FYI, I changed the way that we are handling this in sphinx-hoverxref for a more permissive way. Instead of overriding the translator completely, I'm just adding the behavior that I need by creating a new class dynamically and inheriting from the translator define by the user (or extension) plus my mixin class with the behavior I need.

This allowed me to make my extension compatible with your theme. I just tested this theme with my extension and they both work nicely together!

So, if you think that you can be compatible with other HTML5Translator that the user could define, you may want to follow a similar pattern to avoid the same problem that I had with your theme.

See the PR at readthedocs/sphinx-hoverxref#42

[jorisvandenbossche]

@humitos thanks! that sounds interesting, that should indeed allow to not have to "hardcode" such support. I moved your comment to an new issue -> #143