nuttx: Register PWM device only if device file is not present #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If configured from menuconfig, device inode is already there there is no need to register it again. It was observed on STM32F7 using a config with those options: ``` CONFIG_STM32F7_TIM1=y CONFIG_STM32F7_TIM1_PWM=y ``` Relate-to: rzr/webthing-iotjs#3 Forwarded: jerryscript-project#1886 Change-Id: I6134f15ead43babe3e5de6a9f0d185f6629f62d2 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
535c678 to
c7d0301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If configured from menuconfig, device inode is already there
there is no need to register it again.
It was observed on STM32F7 using a config with those options:
Relate-to: rzr/webthing-iotjs#3
Forwarded: https://github.com/pando-project/iotjs/pull/
Change-Id: I6134f15ead43babe3e5de6a9f0d185f6629f62d2
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com