Skip to content

Conversation

@akosthekiss
Copy link
Member

Both documentation and travis makefile were referring to NuttX 7.22,
which was released in Sep 2017. This commit bumps the version to the
latest release (7.27, from Nov 2018).

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

rm -f $(OBJS)

clean: cleanlibs
clean:: cleanlibs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional? This looks accidental to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is intentional. NuttX makefiles have changed and the clean target became a double-colon rule. From the docs:

When a target appears in multiple rules, all the rules must be the same type: all ordinary, or all double-colon.

So, I had to update the clean rule here, too.

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Both documentation and travis makefile were referring to NuttX 7.22,
which was released in Sep 2017. This commit bumps the version to the
latest release (7.27, from Nov 2018).

Additionally, it also sets the stlink tool to a fixed (and tagged)
version.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
@rtakacs
Copy link
Contributor

rtakacs commented Jan 15, 2019

LGTM (informally).

I've tested this PR and it works fine until the 0c20f8e JerryScript commit (Jan 8 - Fix broken links in README). After that commit (from 99b968d), JerryScript doesn't work well neither with NuttX-7.27 nor with earlier NuttX versions. But this bug is not from this PR, the 99b968d commit should be checked.

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rtakacs thank you for checking. LGTM

@akosthekiss akosthekiss merged commit a9c3ddf into jerryscript-project:master Jan 15, 2019
@akosthekiss akosthekiss deleted the nuttx-7.27 branch January 15, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants