Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timeout for DialContext #678

Closed
wants to merge 1 commit into from
Closed

feat: add timeout for DialContext #678

wants to merge 1 commit into from

Conversation

szza
Copy link

@szza szza commented Feb 5, 2025

1. Are you opening this pull request for bug-fix, optimization or new feature?

  • new feature

2. Please describe how these code changes achieve your intention.

use gent/client to dial remote with timeout

3. Please link to the relevant issues (if any).

4. What documentation changes (if any) need to be made/updated because of this PR?

4. Checklist

  • I have squashed all insignificant commits.
  • I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • I have written unit tests and verified that all tests passes (if needed).
  • I have documented feature info on the README (only when this PR is adding a new feature).
  • (optional) I am willing to help maintain this change if there are issues with it later.

@panjf2000
Copy link
Owner

Thanks for the PR! But I don't think we need this new method as we can call net.DialTimeout and then call gnet.Client.EnrollContext.

@szza szza closed this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants