Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open to all users? #6

Closed
amanalar opened this issue Dec 27, 2018 · 10 comments
Closed

open to all users? #6

amanalar opened this issue Dec 27, 2018 · 10 comments
Labels
bug Something isn't working

Comments

@amanalar
Copy link

not sure if it's intended or if there's a setting I missed. I enabled this using windows docker. One of my friends said he could go into plugins and see my youtube. Meaning my subscriptions and history. Same for subzero, he can go in and change settings.

Is that intended? I was kind of hoping people would use the plugins and enable YouTubeTV.bundle for themselves;

Also, is there a way to hideplugins? I rather not have the outside world be able to change SZ or WebTools plugins.

thanks,

@pannal
Copy link
Owner

pannal commented Dec 27, 2018

Kitana is a plugin proxy for Plex. It mirrors exactly what it receives from the PMS - for the user that's currently requesting a plugin list.

If your settings allow your friends to access plugins (I wasn't aware this was possible), they can do that.

One of my friends said he could go into plugins and see my youtube.

I'm not sure how the YT plugin works. If it has a centralized user configured and only works that way, that's how it'll behave. Again, nothing Kitana can change.

I can add a restriction to only allow certain plugins for non-owner users for example, but that's about it.

@amanalar
Copy link
Author

So definitely some confusion here, mainly on my part :)

The PMS option to share plugins has never worked at least for plugins. Enabling that only shared my access to the news/webshows/podcasts "channels".

In your description you wrote "Kitana exposes your Plex plugin interfaces "to the outside world".

What I took that to mean is that finally I can share plugins like YouTubeTV.Bundle. So people who have access to my server could sign in to youtube that way. From your response I believe the intention is for the PMS owner to have access to the plugin outside the home network, is that right?

Now that I think I have a grip on everything happening here.

In a perfect world what I'd want is for all users to be able to log in to their own youtube account from the plugin but I understand you don't have control over that.

I have a lot of users that log in from xbox or ps3/4. I can just make a youtube account specifically for my PMS so anyone can just use the plugin.

"I can add a restriction to only allow certain plugins for non-owner users for example, but that's about it."

If I can pick which plugins then yes. I really would appreciate that. I can close webtools and SZ and leave YTB open.

@pannal
Copy link
Owner

pannal commented Dec 28, 2018

In your description you wrote "Kitana exposes your Plex plugin interfaces "to the outside world".

Ah yeah I see how that can be understood that way. I'll rephrase that.

After the new year I'll try to get a new build out with the whitelist/blacklist feature.

How do your users access the plugins remotely? Are they using locally enabled/family accounts and not the sharing (for which plugins doesn't seem to work)?

@amanalar
Copy link
Author

Thanks for that, all my users are under sharing not home users

@pannal
Copy link
Owner

pannal commented Dec 28, 2018

Then I might be misunderstanding you there. They actually can access your plugins remotely?

@amanalar
Copy link
Author

Yes, tested on second account as a sharing user. I have access to plugins

@pannal
Copy link
Owner

pannal commented Dec 28, 2018

Ok, weird. I can't access the plugins of the servers shared with me at all. It won't even let me connect to the servers properly.

How would you like the whitelist/blacklist to work? It won't really keep someone from using their own kitana instance to access your plugins then. It will only keep them from using your plugins using your kitana instance.

@amanalar
Copy link
Author

Oh hmm, I know this isn't what you intended, would it be possible to block some plugins from accessing the outside world

@amanalar
Copy link
Author

amanalar commented Dec 28, 2018

So I wanted to be sure before I commented any further. I am able to recreate this. This is what my normal sharing account sees when pointing to my PMS and with "Allow Plugins under Restrictions". The "Plugins" folder is now available to it.

screenshot dec 27 2018 9_22_20 pm

@ukdtom
Copy link

ukdtom commented Jul 11, 2019

Late to the party here ;)

But in WebTools, I only allow access if user is the server owner

https://github.com/ukdtom/WebTools.bundle/blob/master/Contents/Code/plextvhelper.py#L63

@pannal pannal added the bug Something isn't working label Oct 12, 2019
@pannal pannal closed this as completed in b4977cb Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants