Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect contributions from the community #20

Open
amotl opened this issue Nov 2, 2019 · 13 comments
Open

Collect contributions from the community #20

amotl opened this issue Nov 2, 2019 · 13 comments

Comments

@amotl
Copy link

amotl commented Nov 2, 2019

Mission

As more and more people are adding features to Grafana Worldmap, we will start an attempt to be the canonical aggregation point for all of them.

We encourage everyone from the community to submit their contributions to this repository in order to prevent further fragmentation.

Background

Some words about the work we did here can be found at [1], [2] and [3]. @daniellee, @ryantxu and @dprokop of Grafana Labs already recognized and appreciated them and signaled interest in mainlining these updates [3], [4], [5]. Saying this, we want to get this into the hands of more people to conduct further testing before doing so.

Testimonials

Thanks for putting all this work into the panel. [...] great to see the community chipping in. All those features look like good additions. (@daniellee)

We massively appreciate your work and improvements on this plugin. They're nothing short of transformational in terms of its usefulness. (@svet-b)

This fork has been getting more constant attention for the last year while the core plugin has not moved. (@ryantxu)

Further development

At some time starting in July 2019, @ryantxu and @dprokop chimed in to provide further maintenance by integrating grafana-toolkit and more.

References: #4, #6, #8 and grafana/grafana#20071.

Thanks again!


[1] https://community.hiveeyes.org/t/grafana-worldmap-panel-ng/1824
[2] grafana#197
[3] https://community.grafana.com/t/giving-the-grafana-worldmap-panel-some-love/17210
[4] grafana#206
[5] grafana#214

@amotl
Copy link
Author

amotl commented Nov 2, 2019

Dear @clackner-gpa,

as we recognize you just added some commits to [1], we would like to encourage you to rebase them on top of the "develop" branch of this repository and are humbly asking to create appropriate pull requests of your amendments.

You and @GridProtectionAlliance will benefit from the improved robustness of this codebase and you might also appreciate that it already received updates from core members of @grafana to bring in things from the future of development within Grafana Labs.

We will try our best to process your updates accordingly.

Thanks already and with kind regards,
Andreas.

[1] https://github.com/GridProtectionAlliance/worldmap-panel

@amotl
Copy link
Author

amotl commented Nov 18, 2019

After reviewing more forks of Worldmap, we recognized @ravithb also added valuable features to his fork [1] and @liuyu81 added some nice adjustments [2]. Integration of further changes within [3] contributed by @svet-b have already been requested through #11. Going further back in time, we also recognized @Mastoast [4] and @DmitryAliskerov [5] added important details. Last but not least, @tobiasdirksen added the fillOpacity option [6].

While I'm unsure about this, we might also have a look at grafana#221 by @xiaobeiyang. However, we should be careful as this might break other features we've already added within this fork.

[1] https://github.com/ravithb/worldmap-panel/
[2] https://github.com/liuyu81/grafana-worldmap-panel
[3] https://github.com/ammpio/worldmap-panel
[4] https://github.com/hlinyer/hlinyer-worldmap-panel
[5] https://github.com/ApicaSystem/Grafana.worldmap-panel/tree/ASM-262
[6] https://github.com/tobiasdirksen/worldmap-panel-todi

@amotl
Copy link
Author

amotl commented Dec 4, 2019

@wetterfrosch recently mentioned that @samhatchett already added Leaflet's heatmap support through grafana#17 / grafana#35. We are tracking this within #32.

@amotl
Copy link
Author

amotl commented Dec 8, 2019

grafana#220 / grafana#221 by @xiaobeiyang fixes rendering in view mode when using JSON endpoint location data.

@amotl
Copy link
Author

amotl commented Dec 9, 2019

While I didn't investigate how this relates to the original Grafana Map Panel or if it is even a fork of that one, we might well have a look at https://github.com/huizhong/grafana-baidumap-panel by @shcolo and @huizhong, which seems to be under active development and might carry some nice gems.

@amotl
Copy link
Author

amotl commented Mar 6, 2020

We just found @JonasProgrammer has made some more changes to the original Worldmap within https://github.com/nhochdrei/worldmap-panel.

@amotl amotl changed the title Streamline collection of community contributions Collect contributions from the community Mar 16, 2020
@amotl
Copy link
Author

amotl commented Mar 16, 2020

We just found @anatolyza has made some changes to this fork within https://github.com/anatolyza/grafana-map-panel. He is working on integrating Leaflet-Geoman, a Leaflet plugin for drawing and editing geometry layers.

@xkilian
Copy link

xkilian commented Jun 4, 2020

@anatolyza Any chance you will eventually be doing a pull request(s) to get some changes back into panodata?

@amotl
Copy link
Author

amotl commented Jun 17, 2020

@anatolyza
Copy link

anatolyza commented Jun 17, 2020 via email

@amotl
Copy link
Author

amotl commented Jun 17, 2020

We just found @barry-luijten has some adjustments within his table-resolve-location-from-json branch.

@amotl
Copy link
Author

amotl commented Aug 12, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants