Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading pants.backend.codegen.protobuf.python fails in dev releases #10425

Closed
stuhood opened this issue Jul 22, 2020 · 3 comments
Closed

Loading pants.backend.codegen.protobuf.python fails in dev releases #10425

stuhood opened this issue Jul 22, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@stuhood
Copy link
Member

stuhood commented Jul 22, 2020

Somewhere between 2.0.0.dev2 and 2.0.0.dev4, loading pants.backend.codegen.protobuf.python from pants wheels in a dev release (see pantsbuild/example-python#26) began to fail.

Running from sources (with light edits to the pants_from_sources script) works fine, so it seems like something is potentially not packaged in the release wheel that should be.

@stuhood
Copy link
Member Author

stuhood commented Jul 22, 2020

Braindumping a bit. The files includes in the release wheels and in the repository sources don't appear to show any differences (according to roughly find ~/src/pants/src/python -name '*.py' | sort -u > sources/files.txt and find /Users/stuhood/.cache/pants/setup/bootstrap-Darwin-x86_64/2.0.0.dev4_py36/lib/python3.6/site-packages/pants -name '*.py' | sort -u > binary/files.txt):

files.diff.txt

I haven't had any luck diffing the set of installed rules either (although that approach was a bit hackier). Will definitely need to further improve rule graph errors to better highlight what might be missing.

@stuhood
Copy link
Member Author

stuhood commented Jul 22, 2020

So, I realized that I was not running from sources with precisely dev4. And sure enough, precisely dev4 fails when run from sources.

HEAD (e4b6476) works from sources. So it is actually possible that #10428 will prevent this moving forward.

I'll kick off another dev release.

@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 22, 2020

This happened in the Pants repo too. It was fixed by #10409. #10428 would have caught this proactively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants