Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve @rule error messages when writing plugins #11254

Open
stuhood opened this issue Nov 30, 2020 · 3 comments
Open

Improve @rule error messages when writing plugins #11254

stuhood opened this issue Nov 30, 2020 · 3 comments
Labels

Comments

@stuhood
Copy link
Member

stuhood commented Nov 30, 2020

After #10764, RuleGraphs are built and errors are rendered much more quickly. But even relative to before, their quality has degraded.

A ton of information is recorded during RuleGraph construction that should allow for improving the situation here. It's likely that the current strategy of "recording all eliminated options and dumping them if something is unsatisfiable at the end of the run" is the wrong approach, and that we should instead be working forward and reporting why each installed rule that might be able to satisfy a dependency was not able to.

@Eric-Arellano

This comment has been minimized.

@Eric-Arellano
Copy link
Contributor

Oh, nvm, they are different things. We can close #10293.

@Eric-Arellano Eric-Arellano reopened this Nov 30, 2020
@stuhood
Copy link
Member Author

stuhood commented Dec 18, 2020

Relates to #11269: monomorphization is why we end up with many copies of rules.

@stuhood stuhood changed the title RuleGraph errors are not helpful Improve @rule error messages when writing plugins Jan 19, 2022
@stuhood stuhood removed the 2022-idea label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants