Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Filesystem changed" after running fmt, tailor, or update-build-files #14466

Open
thejcannon opened this issue Feb 13, 2022 · 6 comments
Open
Labels

Comments

@thejcannon
Copy link
Member

Describe the bug

06:27:50.93 [INFO] Initializing scheduler...
06:27:51.22 [INFO] Scheduler initialized.
06:27:52.78 [INFO] Completed: Format with Autoflake - autoflake made no changes.                                                                                                                
06:27:54.12 [WARN] Completed: Format with Black - black made changes.                                                                                                                           
reformatted src/python/pants/option/option_types.py

All done! ✨ 🍰 ✨
1 file reformatted.


06:27:55.25 [WARN] Completed: Format with docformatter - docformatter made changes.                                                                                                             
06:27:55.37 [INFO] Completed: Format with isort - isort made no changes.                                                                                                                        

✓ autoflake made no changes.
+ black made changes.
+ docformatter made changes.
✓ isort made no changes.
06:27:55.37 [INFO] Filesystem changed during run: retrying `Fmt` in 500ms...

Pants version
4b335cdccfebcbd1f92caaa5fef7d5ca161c7226

OS
Linux

Additional info
N/A

@thejcannon thejcannon added the bug label Feb 13, 2022
@thejcannon
Copy link
Member Author

The log confirms the file is in fact "src/python/pants/option/option_types.py"

@stuhood
Copy link
Member

stuhood commented Feb 17, 2022

#10705 addresses having better behavior when something has been hand edited... but avoiding logging when a goal has made an actual meaningful change to disk is challenging. #10542 is also relevant maybe.

@stuhood stuhood changed the title "Filesystem changed" after running fmt "Filesystem changed" after running fmt, tailor, or update-build-files Mar 9, 2022
@asherf
Copy link
Member

asherf commented Mar 9, 2022

this also happens when running the tailor goal on a repo as part of the when onboarding a repo to pants.
Filesystem changed during run: retrying TailorGoal in 500ms.

@stuhood
Copy link
Member

stuhood commented Mar 9, 2022

For the record: the goal won't actually restart (because it will have marked itself as side-effected via), so this is purely a spurious message. But yea, let's keep this open until we can tackle it via either #10705 or #10542.

@MatejBabis
Copy link

I can report the same thing happening to me with test as well.

I am new to Pants and I have a monorepo setup which I am currently trying to migrate to work it. So far I have been successful, but one of the "packages" is struggling with the error above. The message itself is not very descriptive, so I am not sure where the issue lies and how to tackle it... Any help/explanation appreciated!

$ ./pants test foo/bar.py                                                                                                                                     
15:50:48.17 [INFO] Initializing scheduler...
15:50:48.34 [INFO] Scheduler initialized.
15:51:02.54 [INFO] Filesystem changed during run: retrying `Test` in 500ms...
15:51:02.55 [INFO] Canceled: Building requirements.pex with 44 requirements: [...]
15:52:02.59 [INFO] Filesystem changed during run: retrying `Test` in 500ms...
15:52:02.65 [INFO] Canceled: Building requirements.pex with 44 requirements: [...]
...

@stuhood
Copy link
Member

stuhood commented May 6, 2022

The message itself is not very descriptive, so I am not sure where the issue lies and how to tackle it... Any help/explanation appreciated!

Sorry about that! The actual file changing will be mentioned in .pants.d/pants.log. Once you determine which file is changing, you'll likely want to ignore it via either .gitignore, or the [GLOBAL].pants_ignore setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants