Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pants lint goal with regex-lint linter ignores changes to the configuration file unless .pids is nuked #15883

Closed
alexey-tereshenkov-oxb opened this issue Jun 21, 2022 · 2 comments
Labels

Comments

@alexey-tereshenkov-oxb
Copy link
Contributor

Describe the bug

When running

$ ./pants lint '**'

using a configuration file loaded with [regex-lint].config in the pants.toml file, changes in the configuration file are ignored unless the .pids directory is removed before re-running the command:

$ rm -r .pids; ./pants lint '**'

Creating a new configuration file and updating the [regex-lint].config in the pants.toml file does not help either.

I expect Pants to re-load the modified configuration out of the configuration file.

Pants version
Pants 2.10, 2.11

OS
MacOS

Additional info

@stuhood
Copy link
Member

stuhood commented Jun 21, 2022

I assume that you are using an @file option with the config? Unfortunately, that is subject to #10360. Will close as a dupe, but please reopen if that's not the case.

Note also that it should be possible to define the config directly in pants.toml (using toml syntax), rather than via an @file, although I haven't seen anyone try it.

@stuhood stuhood closed this as completed Jun 21, 2022
@alexey-tereshenkov-oxb
Copy link
Contributor Author

Oh thanks @stuhood -- sorry my search for existing issues around it failed... yep, I use the @file syntax. I'll experiment on using the regex-linter in CI -- perhaps this is going to be fine given a build starts in a fresh container, so .pids won't be preserved.

@Eric-Arellano Eric-Arellano closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants