Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-skip or delete isolated_process tests #5634

Closed
illicitonion opened this issue Mar 27, 2018 · 2 comments
Closed

Un-skip or delete isolated_process tests #5634

illicitonion opened this issue Mar 27, 2018 · 2 comments
Assignees
@cosmicexplorer

Comments

@illicitonion
Copy link
Contributor

3 tests in https://github.com/pantsbuild/pants/blob/master/tests/python/pants_test/engine/test_isolated_process.py are skipped. We should work out a way to get snapshot contents in tests, and un-skip the tests.
@illicitonion illicitonion mentioned this issue Mar 27, 2018
Closed
@stuhood
Copy link
Member

stuhood commented Mar 27, 2018

We should work out a way to get snapshot contents in tests, and un-skip the tests.

Currently that would look like requesting FilesContent for the Snapshot. But I just went down a little mental rabbit hole where I imagined integration tests implemented as @rules. Mmm.

@illicitonion illicitonion assigned cosmicexplorer and unassigned ity Apr 16, 2018
@illicitonion
Copy link
Contributor Author

Underway in #5703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cosmicexplorer cosmicexplorer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stuhood @illicitonion @ity @cosmicexplorer