Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Options parsing @rules with engine I/O for file_option and dir_option #5935

Closed
kwlzn opened this issue Jun 8, 2018 · 1 comment
Closed

Improve Options parsing @rules with engine I/O for file_option and dir_option #5935

kwlzn opened this issue Jun 8, 2018 · 1 comment
Assignees
@kwlzn

Comments

@kwlzn
Copy link
Member

kwlzn commented Jun 8, 2018

a TODO spawned from #5831. these currently require direct I/O, but should use the engine.

@stuhood was thinking we could just ban paths outside of the buildroot to make this easier. I had similar thoughts but wasn't sure if that would fly long term (e.g. /tmp would be off limit).
@kwlzn kwlzn added the engine label Jun 8, 2018
@kwlzn kwlzn self-assigned this Jun 8, 2018
@kwlzn kwlzn mentioned this issue Jun 8, 2018
Merged
@stuhood
Copy link
Member

stuhood commented Sep 28, 2018

Resolving in favor of #5869.

@stuhood stuhood closed this as completed Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwlzn kwlzn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuhood @kwlzn